[webkit-reviews] review granted: [Bug 131064] [CSS Grid Layout] Split the grid-item-margin-auto-columns-rows.html test. : [Attachment 228333] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 22 02:46:09 PDT 2014


Benjamin Poulain <benjamin at webkit.org> has granted Javier Fernandez
<jfernandez at igalia.com>'s request for review:
Bug 131064: [CSS Grid Layout] Split the grid-item-margin-auto-columns-rows.html
test.
https://bugs.webkit.org/show_bug.cgi?id=131064

Attachment 228333: Patch
https://bugs.webkit.org/attachment.cgi?id=228333&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
Splitting text seems like a good idea. Just rename the horiz and vert to
horizontal and vertical. No point in abbreviating.
Shouldn't grid-item-margin-auto-columns-rows be named horizontal-ltr for
consistency? Does it test something else?


More information about the webkit-reviews mailing list