[webkit-reviews] review denied: [Bug 131415] Improve support for SVN statuses in scm.py : [Attachment 231854] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Matthew Hanson
<matthew_hanson at apple.com>'s request for review:
Bug 131415: Improve support for SVN statuses in scm.py
https://bugs.webkit.org/show_bug.cgi?id=131415

Attachment 231854: Patch
https://bugs.webkit.org/attachment.cgi?id=231854&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231854&action=review


> Tools/Scripts/webkitpy/common/checkout/scm/status.py:6
> +	   self.file_statuses = [FileStatus(line, checkout_root) for line in
text.split("\n") if line]

We usually prefix private variables with _.

> Tools/Scripts/webkitpy/common/checkout/scm/status.py:45
> +class FileStatus(object):

FileStatus is an extremely generic name.  Please give it a more descriptive
name.

> Tools/Scripts/webkitpy/common/checkout/scm/status.py:73
> +    # Status convenience methods

Can't we use __getattr__ to implement these instead?

> Tools/Scripts/webkitpy/common/checkout/scm/status.py:175
> +class Code(object):

Code is an extremely generic class name.  Please give it a more descriptive
name.

> Tools/Scripts/webkitpy/common/checkout/scm/status.py:194
> +ItemReplaced = Code(1, "R", "Item has been replaced in your working "
> +			       "copy. This means the file was scheduled "
> +			       "for deletion, and then a new file with "
> +			       "the same name was scheduled for addition "
> +			       "in its place.")

We don't align text line this with indentations.  Please indent each line with
exactly 4 spaces.
Also, these descriptions are split into so many lines.	We can probably fit
this into much fewer lines.