[webkit-reviews] review granted: [Bug 133169] Don't create huge backing stores when transforms cause layer scaling : [Attachment 231857] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 22 00:31:55 PDT 2014


Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 133169: Don't create huge backing stores when transforms cause layer
scaling
https://bugs.webkit.org/show_bug.cgi?id=133169

Attachment 231857: Patch
https://bugs.webkit.org/attachment.cgi?id=231857&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231857&action=review


> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2170
> +	   for (size_t i = 0; i < animations.size(); ++i) {

range-based for?

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2172
> +		   runningAnimations.remove(currAnimationName);

can you use the iterator from earlier?

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2443
> +    for (auto it = animations.begin(); it != animations.end(); ++it) {

range-based for here too, maybe?


More information about the webkit-reviews mailing list