[webkit-reviews] review granted: [Bug 133166] [ftlopt] DFG::clobberize should be blind to the effects of GC : [Attachment 231851] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 133166: [ftlopt] DFG::clobberize should be blind to the effects of GC
https://bugs.webkit.org/show_bug.cgi?id=133166

Attachment 231851: the patch
https://bugs.webkit.org/attachment.cgi?id=231851&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231851&action=review


r=me

> Source/JavaScriptCore/dfg/DFGDoesGC.cpp:37
> +    switch (node->op()) {

Might be nice to list all the ops here explicitly, and remove the default. That
would make it impossible to add a new op without considering whether it does
GC.