[webkit-reviews] review requested: [Bug 133162] [iOS][WK2] Add support for minimal-ui viewports : [Attachment 231846] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 21 18:27:13 PDT 2014
Tim Horton <thorton at apple.com> has asked for review:
Bug 133162: [iOS][WK2] Add support for minimal-ui viewports
https://bugs.webkit.org/show_bug.cgi?id=133162
Attachment 231846: Patch
https://bugs.webkit.org/attachment.cgi?id=231846&action=review
------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231846&action=review
> Source/WebCore/ChangeLog:14
> + Initialy, the page is initialized with resetMinimalUI() and start
with a normal layout.
typo "initially"
> Source/WebKit2/ChangeLog:8
> + In the WebKit2 layers, we have two part to minimal-ui.
typo "parts"
> Source/WebKit2/ChangeLog:10
> + An other part is freezing the state on the first frame.
typo "another"
> Source/WebCore/page/ViewportConfiguration.cpp:117
> +void ViewportConfiguration::pageWillRenderFirstFrame()
I have already registered my objection to this part :D
More information about the webkit-reviews
mailing list