[webkit-reviews] review granted: [Bug 133143] Special handling of telephone number detection menu : [Attachment 231813] Patch v1

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 133143: Special handling of telephone number detection menu
https://bugs.webkit.org/show_bug.cgi?id=133143

Attachment 231813: Patch v1
https://bugs.webkit.org/attachment.cgi?id=231813&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231813&action=review


r=me

> Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:462
> +    // In the future all other menus we should probably eiher use that API
or the

This comment confused me a little, because it seemed like you were saying that
it's a FIXME that telephone number menus use this API. But I think you're
actually saying that telephone menus are better than all other menus, and it's
a FIXME to fix the other menus.

So, maybe put the FIXME before the second sentence instead of the first?

Also: Typos in "other menus we should probably eiher use".