[webkit-reviews] review denied: [Bug 131094] Remove one of the CSSProperty constructor : [Attachment 231687] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Zsolt Borbely
<zsborbely.u-szeged at partner.samsung.com>'s request for review:
Bug 131094: Remove one of the CSSProperty constructor
https://bugs.webkit.org/show_bug.cgi?id=131094

Attachment 231687: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=231687&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231687&action=review


> Source/WebCore/css/StyleProperties.h:70
> +	   bool isSetFromShorthand() const { return
propertyMetadata().m_isSetFromShorthand; }
> +	   int indexInShorthandsVector() const { return
propertyMetadata().m_indexInShorthandsVector; }

Please don’t add these new public member functions. We don’t need the functions
at all, since they are only used in one place and that’s inside this class. And
if you really felt compelled to add the functions, they should be private since
they are only used by a member function.