[webkit-reviews] review granted: [Bug 133149] REGRESSION(r169092 and r169102): Skip failing JSC tests on ARM64 properly : [Attachment 231825] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 21 07:25:55 PDT 2014


Csaba Osztrogonác <ossy at webkit.org> has granted Éva Balázsfalvi
<evab.u-szeged at partner.samsung.com>'s request for review:
Bug 133149: REGRESSION(r169092 and r169102): Skip failing JSC tests on ARM64
properly
https://bugs.webkit.org/show_bug.cgi?id=133149

Attachment 231825: Patch
https://bugs.webkit.org/attachment.cgi?id=231825&action=review

------- Additional Comments from Csaba Osztrogonác <ossy at webkit.org>
LGTM, r=me. 

Now the $architerture is always nil on non Mac, because
machO magic is Mac only, on Linux we use ELF file format.

Maybe we should implement a similar thing for ELF too.
But it's not a problem now, because there are only skipped
tests on ARM64, and there aren't any ARM64 hardware to run
tests except the newest iPhone. :)


More information about the webkit-reviews mailing list