[webkit-reviews] review granted: [Bug 133129] [Mac] Allow popup menus to override default appearance : [Attachment 231786] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 133129: [Mac] Allow popup menus to override default appearance
https://bugs.webkit.org/show_bug.cgi?id=133129

Attachment 231786: Patch
https://bugs.webkit.org/attachment.cgi?id=231786&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231786&action=review


> Source/WebCore/platform/PopupMenuStyle.h:46
> -    PopupMenuStyle(const Color& foreground, const Color& background, const
Font& font, bool visible, bool isDisplayNone, Length textIndent, TextDirection
textDirection, bool hasTextDirectionOverride, BackgroundColorType
backgroundColorType = DefaultBackgroundColor, PopupMenuType menuType =
SelectPopup, PopupMenuSize menuSize = PopupMenuSizeNormal)
> +    PopupMenuStyle(const Color& foreground, const Color& background, const
Font& font, bool visible, bool isDisplayNone, bool hasDefaultAppearance, Length
textIndent, TextDirection textDirection, bool hasTextDirectionOverride,
BackgroundColorType backgroundColorType = DefaultBackgroundColor, PopupMenuType
menuType = SelectPopup, PopupMenuSize menuSize = PopupMenuSizeNormal)

yikes. this could really use some cleaning up.