[webkit-reviews] review granted: [Bug 133105] [ftlopt] DFG bytecode parser should turn GetById with nothing but a Getter stub as stuff+handleCall, and handleCall should be allowed to inline if it wants to : [Attachment 231776] the patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 133105: [ftlopt] DFG bytecode parser should turn GetById with nothing but a
Getter stub as stuff+handleCall, and handleCall should be allowed to inline if
it wants to
https://bugs.webkit.org/show_bug.cgi?id=133105

Attachment 231776: the patch
https://bugs.webkit.org/attachment.cgi?id=231776&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231776&action=review


r=me provided you address the two issues raised in
GetByIdStatus::computeForStubInfo().

> Source/JavaScriptCore/bytecode/GetByIdStatus.cpp:127
> +    State takesSlowPath = TakesSlowPath;

The name takesSlowPath is confusing since it can have the value MakesCalls.

> Source/JavaScriptCore/bytecode/GetByIdStatus.cpp:132
> +	   for (unsigned i = 0; i < list->size(); ++i)
> +	       takesSlowPath = MakesCalls;

Why is this a loop?  Are you missing "if (list->at(i).doesCalls())"?

> Source/JavaScriptCore/jit/JIT.h:245
> +	   

Extraneous space - delete