[webkit-reviews] review granted: [Bug 133011] JSArray::shiftCountWith* could be more efficient : [Attachment 231730] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 19 19:28:01 PDT 2014


Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 133011: JSArray::shiftCountWith* could be more efficient
https://bugs.webkit.org/show_bug.cgi?id=133011

Attachment 231730: Patch
https://bugs.webkit.org/attachment.cgi?id=231730&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231730&action=review


r=me

> Source/JavaScriptCore/runtime/Structure.cpp:390
> +bool Structure::holesRequireSpecialBehavior(VM& vm) const

Maybe we can be more specific and call this something like
"holesMustForwardToPrototype".


More information about the webkit-reviews mailing list