[webkit-reviews] review granted: [Bug 133099] WebKit2/iOS: parented view should be considered hidden if app is backgrounded : [Attachment 231743] Fix

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 133099: WebKit2/iOS: parented view should be considered hidden if app is
backgrounded
https://bugs.webkit.org/show_bug.cgi?id=133099

Attachment 231743: Fix
https://bugs.webkit.org/attachment.cgi?id=231743&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231743&action=review


> Source/WebKit2/ChangeLog:3
> +	   WebKit2/iOS: view is not visible if app is not foreground.

Please update from the bugzilla.
Is there a relevant radar?

> Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:111
>  bool PageClientImpl::isViewWindowActive()

isViewsWindowActive?

> Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:114
> +    return isViewVisible();

Not clear what the implications of isViewWindowActive are.