[webkit-reviews] review granted: [Bug 133088] [iOS] Make fast/dom/remove-element-with-{id|name}-that-was-inserted-on-DOMNodeRemoved.html reliable : [Attachment 231728] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 19 18:06:05 PDT 2014


Alexey Proskuryakov <ap at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 133088: [iOS] Make
fast/dom/remove-element-with-{id|name}-that-was-inserted-on-DOMNodeRemoved.html
reliable
https://bugs.webkit.org/show_bug.cgi?id=133088

Attachment 231728: Patch v1
https://bugs.webkit.org/attachment.cgi?id=231728&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231728&action=review


> LayoutTests/ChangeLog:11
> +	   - Use waitUntilDone()/notifyDone() to make the tests reliable on
> +	     iOS with the WebThread enabled.

I think that there is nothing special about iOS DumpRendreTree here - these
tests have a setTimeout that races with parsing. They could fail on OS X as
well.


More information about the webkit-reviews mailing list