[webkit-reviews] review requested: [Bug 87846] vw/vh units used as font/line-height values don't scale with the viewport : [Attachment 231724] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 19 14:29:10 PDT 2014


Bem Jones-Bey <bjonesbe at adobe.com> has asked  for review:
Bug 87846: vw/vh units used as font/line-height values don't scale with the
viewport
https://bugs.webkit.org/show_bug.cgi?id=87846

Attachment 231724: Patch
https://bugs.webkit.org/attachment.cgi?id=231724&action=review

------- Additional Comments from Bem Jones-Bey <bjonesbe at adobe.com>
Addressed all the review feedback except this patch is still walking the DOM
tree. I don't see an iterator for this walk of the DOM tree, and there isn't
even a traversal function (much less an iterator) to traverse the entire render
tree. I also looked into changing it to save the renderers or elements that
have viewport units so that we would only have to iterate over those, but I
haven't been able to come up with an approach that would work there. I would be
happy to add an iterator so that this can iterate over the render tree, but I
would like to do that in a future patch.


More information about the webkit-reviews mailing list