[webkit-reviews] review denied: [Bug 127938] Web Inspector: Inspect Element sometimes does not select the right DOM Node : [Attachment 231718] [PATCH] Proposed Fix: Addition of NavigationSidebar#isElementSelected getter REV 3

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has denied Jono Wells
<jonowells at apple.com>'s request for review:
Bug 127938: Web Inspector: Inspect Element sometimes does not select the right
DOM Node
https://bugs.webkit.org/show_bug.cgi?id=127938

Attachment 231718: [PATCH] Proposed Fix: Addition of
NavigationSidebar#isElementSelected getter REV 3
https://bugs.webkit.org/attachment.cgi?id=231718&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231718&action=review


> Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:275
> +	   this._restoreSelectedNodeIsAllowed = true;
>	   var node = this._idToDOMNode[nodeId];

Style: lets put an empty newline after setting the state.

> Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:285
> +	   this._restoreSelectedNodeIsAllowed = false;

Style: lets put an empty newline after setting the state.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:297
> +	   if (!WebInspector.domTreeManager.restoreSelectedNodeIsAllowed)
> +	       return;

The same check should be done in selectLastSelectedNode below, which is what
can be called async, and we don't want to restore the selected node in the
async case.