[webkit-reviews] review canceled: [Bug 132951] CSS JIT: Apply backtracking optimization to adjacent backtracking : [Attachment 231508] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has canceled Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 132951: CSS JIT: Apply backtracking optimization to adjacent backtracking
https://bugs.webkit.org/show_bug.cgi?id=132951

Attachment 231508: Patch
https://bugs.webkit.org/attachment.cgi?id=231508&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
Looking into this in detail, I think the design is good.

Yesterday I thought we should unify
solveDescendantBacktrackingActionForChild-solveAdjacentBacktrackingActionForDir
ectAdjacent and
computeBacktrackingHeightFromDescendant-computeBacktrackingWidthFromIndirectAdj
acent...but looking into this more I am less convinced.

We could templatize the functions to do that, but I think that would hurt
readability. A little duplication is okay if the result is clearer.

I clear the review flag to remove the patch from the review queue until you add
the tests.