[webkit-reviews] review granted: [Bug 133017] Expose WKUserScript as API : [Attachment 231604] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 133017: Expose WKUserScript as API
https://bugs.webkit.org/show_bug.cgi?id=133017

Attachment 231604: Patch
https://bugs.webkit.org/attachment.cgi?id=231604&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231604&action=review


> Source/WebKit2/UIProcess/UserContent/WebUserContentControllerProxy.h:41
> +class WebUserContentControllerProxy final : public
RefCounted<WebUserContentControllerProxy> {

There is nothing virtual about this class. Does adding final really help here?

> Source/WebKit2/WebProcess/UserContent/WebUserContentController.h:51
> +private:

This private is redundant.

> Source/WebKit2/WebProcess/UserContent/WebUserContentController.h:53
> +    RefPtr<WebCore::UserContentController> m_userContentController;

This could probably be a Ref<WebCore::UserContentController>
m_userContentController;