[webkit-reviews] review granted: [Bug 133072] Navigations tests: http/tests/navigation/forward-to-fragment-fires-onload.html fails. : [Attachment 231697] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Jono Wells <jonowells at apple.com>'s
request for review:
Bug 133072: Navigations tests:
http/tests/navigation/forward-to-fragment-fires-onload.html fails.
https://bugs.webkit.org/show_bug.cgi?id=133072

Attachment 231697: Patch
https://bugs.webkit.org/attachment.cgi?id=231697&action=review

------- Additional Comments from Andy Estes <aestes at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231697&action=review


> LayoutTests/http/tests/navigation/forward-to-fragment-fires-onload.html:11
> -description('Tests that loading is not stopped by going forward to a
fragment.');
> +description("Tests to see that loading is not stopped by going forward to a
fragment.");

I wouldn't change these to double quotes. It'll just make it harder for someone
to blame this file later on.

> LayoutTests/http/tests/navigation/forward-to-fragment-fires-onload.html:17
> -    if (window.localStorage.stage == 'three') {
> -	   console.log('3. Got back to start.  Going forward to page 2.');
> -	   window.localStorage.stage = 'four';
> +    if (window.localStorage.stage == "three") {
> +	   console.log("3. Got back to start.  Going forward to page 2.");
> +	   window.localStorage.stage = "four";

Ditto.

> LayoutTests/http/tests/navigation/forward-to-fragment-fires-onload.html:19
> -    } else if (window.localStorage.stage == 'six') {
> +    } else if (window.localStorage.stage == "six") {

Ditto.

> LayoutTests/http/tests/navigation/forward-to-fragment-fires-onload.html:27
> -	   console.log('Starting test.');
> -	   window.localStorage.stage = 'one';
> +	   console.log("Starting test.");
> +	   window.localStorage.stage = "one";

Ditto.

> LayoutTests/http/tests/navigation/forward-to-fragment-fires-onload.html:30
> -	       window.location.href =
'resources/forward-to-fragment-fires-onload-2.html';
> +	       window.location.href =
"resources/forward-to-fragment-fires-onload-2.html";

Ditto.