[webkit-reviews] review granted: [Bug 133043] AX: iOS: using AXAttributeCacheEnabler is too slow for every accessibilityElementAtIndex: : [Attachment 231650] patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 133043: AX: iOS: using AXAttributeCacheEnabler is too slow for every
accessibilityElementAtIndex:
https://bugs.webkit.org/show_bug.cgi?id=133043

Attachment 231650: patch
https://bugs.webkit.org/attachment.cgi?id=231650&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231650&action=review


> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:346
> +   
m_object->axObjectCache()->startCachingComputedObjectAttributesUntilTreeMutates
();

Perhaps you want to check whether axObjectCache() returns null here before
using it?

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:351
> +    m_object->axObjectCache()->stopCachingComputedObjectAttributes();

Same comment here