[webkit-reviews] review denied: [Bug 133062] [WebKit2] Cleanup the build from unused variable in WebProcess module : [Attachment 231675] Patch

[bugzilla-daemon at webkit.org]

Csaba Osztrogonác <ossy at webkit.org> has denied Shivakumar J M
<shiva.jm at samsung.com>'s request for review:
Bug 133062: [WebKit2] Cleanup the build from unused variable in WebProcess
module
https://bugs.webkit.org/show_bug.cgi?id=133062

Attachment 231675: Patch
https://bugs.webkit.org/attachment.cgi?id=231675&action=review

------- Additional Comments from Csaba Osztrogonác <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231675&action=review


> Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:144
> +    UNUSED_PARAM(scriptMessageHandlers);

scriptMessageHandlers is used if ENABLE(USER_MESSAGE_HANDLERS) 
is true, it should be placed in the #else case, like this:

#if ENABLE(USER_MESSAGE_HANDLERS)
   ...
#else
    UNUSED_PARAM(scriptMessageHandlers);
#endif

> Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:157
> +    UNUSED_PARAM(identifier);

ditto