[webkit-reviews] review granted: [Bug 132773] Text decorations do not contribute to visual overflow : [Attachment 231679] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 132773: Text decorations do not contribute to visual overflow
https://bugs.webkit.org/show_bug.cgi?id=132773

Attachment 231679: Patch
https://bugs.webkit.org/attachment.cgi?id=231679&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=231679&action=review


r=me

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:533
> +    if (glyphOverflow.top || glyphOverflow.bottom || glyphOverflow.left ||
glyphOverflow.right) {

!glyphOverflow.isEmpty() (since you added it)