[webkit-reviews] review requested: [Bug 133028] Build break of 2.4.1 under mingw32/msys : [Attachment 231632] miscellaenous changes

[bugzilla-daemon at webkit.org]

Milan Crha <mcrha at redhat.com> has asked  for review:
Bug 133028: Build break of 2.4.1 under mingw32/msys
https://bugs.webkit.org/show_bug.cgi?id=133028

Attachment 231632: miscellaenous changes
https://bugs.webkit.org/attachment.cgi?id=231632&action=review

------- Additional Comments from Milan Crha <mcrha at redhat.com>
This is the last set, quite miscellaneous changes related to:
a) Source/WTF/wtf/Atomics.h - do not use MSVC code for mingw32
b) missing WTF/WTFHeaderDetection.h
c) PLATFORM(WIN) doesn't seem to work the same as OS(WINDOWS), but as long as
BinarySemaphore.h uses OS(WINDOWS), the BinarySemaphore.cpp should as well (and
it works fine if it does)
d) PluginPackageNone.cpp/PluginViewNone.cpp might not be used on windows, win32
build has its own implementation for these
e) missing #include <windows.h> in
Source/WebCore/platform/gtk/FileSystemGtk.cpp
f) Source/WebCore/rendering/RenderBlock.cpp - the check for structure size
fails on mingw32/msys, the enum size or the split of bit fields make the
structure larger than with a 32bit uint, thus I both moved the bit fields to be
in one group, and then added enum into the "control" structure