[webkit-reviews] review granted: [Bug 132988] Link search area for touch events is too large in some cases : [Attachment 231585] patch3

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 132988: Link search area for touch events is too large in some cases
https://bugs.webkit.org/show_bug.cgi?id=132988

Attachment 231585: patch3
https://bugs.webkit.org/attachment.cgi?id=231585&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231585&action=review


> Source/WebCore/page/ios/FrameIOS.mm:435
> +    float scale = page() ? page()->pageScaleFactor() : 1;

I don't know how we'd ever get here with a null page.

> Source/WebCore/page/ios/FrameIOS.mm:-469
> -	   // We don't approximate the node if we are dragging, we instead
force the user to be precise.

Did the code related to this comment disappear some time in the past?

> Source/WebCore/platform/ios/PlatformScreenIOS.mm:102
> +float mainScreenRelativePPI()

This name still confuses me. It sounds more like a screenPPIFactor(), and a
comment in the header should say what it's relative to.