[webkit-reviews] review granted: [Bug 132994] [Mac] naturalSize not updated when preload=metadata : [Attachment 231582] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 16 12:22:35 PDT 2014
Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 132994: [Mac] naturalSize not updated when preload=metadata
https://bugs.webkit.org/show_bug.cgi?id=132994
Attachment 231582: Patch
https://bugs.webkit.org/attachment.cgi?id=231582&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231582&action=review
>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:1485
> + if (AVAssetTrack* firstVideoTrack = [videoTracks firstObject])
> +
presentationSizeDidChange(IntSize(CGSizeApplyAffineTransform([firstVideoTrack
naturalSize], [firstVideoTrack preferredTransform])));
> + else
> + presentationSizeDidChange(IntSize());
This won't be correct if the first video track isn't enabled.
More information about the webkit-reviews
mailing list