[webkit-reviews] review granted: [Bug 132973] [MSE] Crash at WebCore::SourceBuffer::~SourceBuffer + 110 : [Attachment 231579] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 16 11:44:39 PDT 2014


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 132973: [MSE] Crash at  WebCore::SourceBuffer::~SourceBuffer + 110
https://bugs.webkit.org/show_bug.cgi?id=132973

Attachment 231579: Patch
https://bugs.webkit.org/attachment.cgi?id=231579&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231579&action=review


>
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.m
m:529
> +	   [parser appendStreamData:nsData.get()];

Nit: is there any reason to append the data if weakThis is already NULL?


More information about the webkit-reviews mailing list