[webkit-reviews] review denied: [Bug 127938] Web Inspector: Inspect Element sometimes does not select the right DOM Node : [Attachment 231542] [PATCH] Proposed Fix: Flag to allow _restoreSelectedNodeAfterUpdate

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has denied Jono Wells
<jonowells at apple.com>'s request for review:
Bug 127938: Web Inspector: Inspect Element sometimes does not select the right
DOM Node
https://bugs.webkit.org/show_bug.cgi?id=127938

Attachment 231542: [PATCH] Proposed Fix: Flag to allow
_restoreSelectedNodeAfterUpdate
https://bugs.webkit.org/attachment.cgi?id=231542&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231542&action=review


Looks good. Only a minor issue.

> Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:44
> +    this._restoreAllowed = true;

_restoreSelectedNodeAllowed?

> Source/WebInspectorUI/UserInterface/Views/FrameDOMTreeContentView.js:74
> +	   if (WebInspector.domTreeManager._restoreAllowed)

This should not access a private property of another class.
_restoreSelectedNodeAllowed should be exposed as a public getter or as
isRestoreSelectedNodeAllowed().