[webkit-reviews] review granted: [Bug 132678] Blob.cpp fails to build with some gcc versions because of signed/unsigned comparison : [Attachment 231560] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 16 09:32:43 PDT 2014
Alexey Proskuryakov <ap at webkit.org> has granted Tanay <tanay.c at samsung.com>'s
request for review:
Bug 132678: Blob.cpp fails to build with some gcc versions because of
signed/unsigned comparison
https://bugs.webkit.org/show_bug.cgi?id=132678
Attachment 231560: Patch
https://bugs.webkit.org/attachment.cgi?id=231560&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231560&action=review
> Source/WebCore/fileapi/Blob.cpp:127
> + m_size = (WTF::isInBounds<long long>(actualSize)) ? static_cast<long
long>(actualSize) : 0;
Does it compile without "WTF::"? Please remove the prefix when landing if it
does.
More information about the webkit-reviews
mailing list