[webkit-reviews] review granted: [Bug 132978] [iOS WK2] When zoomed, fixed elements jump at the start of a scroll, and jump back at the end. : [Attachment 231550] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 132978: [iOS WK2] When zoomed, fixed elements jump at the start of a
scroll, and jump back at the end.
https://bugs.webkit.org/show_bug.cgi?id=132978

Attachment 231550: Patch
https://bugs.webkit.org/attachment.cgi?id=231550&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231550&action=review


> Source/WebKit2/UIProcess/PageClient.h:260
> +    virtual float minimumZoomScale() const = 0;

float->double
minimumZoomScale->displayedContentMinimumZoomScale().

> Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:192
> +    if (UIScrollView *scroller = [m_contentView _scroller])

I am trying to get rid of all the _scroller.

You can use [m_webView scrollView] here instead.

> Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:214
> +WebCore::FloatRect WebPageProxy::computeCustomFixedPositionRect(const
FloatRect& unobscuredContentRect, float scale, UnobscuredRectConstraint
constraint) const

float -> double.
scale -> displayedContentScale for clarity.