[webkit-reviews] review granted: [Bug 132975] old-run-webkit-tests: allow specifying a simulator app path : [Attachment 231544] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted David Farler
<dfarler at apple.com>'s request for review:
Bug 132975: old-run-webkit-tests: allow specifying a simulator app path
https://bugs.webkit.org/show_bug.cgi?id=132975

Attachment 231544: Patch
https://bugs.webkit.org/attachment.cgi?id=231544&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231544&action=review


r=me, but consider providing a more specific default as well based on $SDKROOT.


> Tools/Scripts/old-run-webkit-tests:191
> +my $simulatorApp = 'iOS Simulator';

Instead of specifying a command-line argument, why not just construct the path
based on the $SDKROOT path?

It's always installed at a well-known location, so we should be able to
construct the path using the $SDKROOT.

I'm surprised there isn't a way to find it using 'xcrun -sdk iphonesimulator',
but maybe that's only for command-line executables.