[webkit-reviews] review denied: [Bug 132897] Use INT_MAX instead of UINT_MAX to indicate end-of-segment : [Attachment 231430] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 15 17:41:49 PDT 2014


Maciej Stachowiak <mjs at apple.com> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 132897: Use INT_MAX instead of UINT_MAX to indicate end-of-segment
https://bugs.webkit.org/show_bug.cgi?id=132897

Attachment 231430: Patch
https://bugs.webkit.org/attachment.cgi?id=231430&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
I think it would be good to have a test that would have triggered the asserts
or crashed. But also: I don't see any asserts in the patch. Is that a bug in
the patch or the ChangeLog? r- for lack of test and for incorrect ChangeLog.
Also please see andersca's comment.


More information about the webkit-reviews mailing list