[webkit-reviews] review denied: [Bug 132939] [WebKit2-EFL] Fix safety check failed errors in API tests : [Attachment 231498] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Shivakumar J M
<shiva.jm at samsung.com>'s request for review:
Bug 132939: [WebKit2-EFL] Fix safety check failed errors in API tests
https://bugs.webkit.org/show_bug.cgi?id=132939

Attachment 231498: Patch
https://bugs.webkit.org/attachment.cgi?id=231498&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231498&action=review


> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:-1146
> -    ewk_view_contents_size_get(0, &contentsWidth, &contentsHeight);

I think this is to check if width and height can be initialized with 0 when
Evas_Object is null. To be honest, I don't know why we have to initialize
width/height when evas object is null.

Eina_Bool ewk_view_contents_size_get(const Evas_Object* ewkView, Evas_Coord*
width, Evas_Coord* height)
{
    EwkView* impl = toEwkViewChecked(ewkView);
    if (EINA_UNLIKELY(!impl)) {
	EINA_LOG_CRIT("no private data for object %p", ewkView);
	if (width)
	    *width = 0;
	if (height)
	    *height = 0;

	return false;
    }

If we remove this test logic, I think we have to remove the initialization code
together.