[webkit-reviews] review granted: [Bug 132918] JSDOMWindow should not claim HasImpureGetOwnPropertySlot : [Attachment 231536] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 132918: JSDOMWindow should not claim HasImpureGetOwnPropertySlot
https://bugs.webkit.org/show_bug.cgi?id=132918

Attachment 231536: Patch
https://bugs.webkit.org/attachment.cgi?id=231536&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231536&action=review


r=me

> Source/WebCore/ChangeLog:12
> +	   We now correctly handle the impurity of JSDOMWindow's custom
getOwnPropertySlot without needing the 
> +	   blanket HasImpureGetOwnPropertySlot. Getting rid of this flag will
allow us to cache many 

Should specify that we do this through explicit watchpoint.