[webkit-reviews] review granted: [Bug 132959] TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac : [Attachment 231522] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 15 09:20:02 PDT 2014


mitz at webkit.org <mitz at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 132959: TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
https://bugs.webkit.org/show_bug.cgi?id=132959

Attachment 231522: Patch v1
https://bugs.webkit.org/attachment.cgi?id=231522&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231522&action=review


> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:963
> +				44A82E7B19251B3500C1C8C4 /* cocoa */,

I know that we have all-lowercase mac group and directory, but in the WebKit2
project and in Source/WebKit2 we’ve been capitalizing but the Cocoa groups in
the project and the Cocoa directories.


More information about the webkit-reviews mailing list