[webkit-reviews] review granted: [Bug 132121] [CSS Regions] Reduce the RenderRegion invasiveness in rendering code : [Attachment 231514] Patch with fixed typo

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andrei Bucur <abucur at adobe.com>'s
request for review:
Bug 132121: [CSS Regions] Reduce the RenderRegion invasiveness in rendering
code
https://bugs.webkit.org/show_bug.cgi?id=132121

Attachment 231514: Patch with fixed typo
https://bugs.webkit.org/attachment.cgi?id=231514&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=231514&action=review


r=me

> Source/WebCore/rendering/RenderLayer.cpp:4475
> +	   PaintInfo paintInfo(context, fragment.foregroundRect.rect(), phase,
paintBehavior, subtreePaintRootForRenderer, 0, 0,
&localPaintingInfo.rootLayer->renderer());

You could also turn 0's into nullptrs here and various other places since you
are touching them.

> Source/WebCore/rendering/RenderLayer.h:713
> +    bool intersectsDamageRect(const LayoutRect& layerBounds, const
LayoutRect& damageRect, const RenderLayer* rootLayer, const LayoutPoint*
offsetFromRoot = 0, const LayoutRect* cachedBoundingBox = 0) const;

nullptr

> Source/WebCore/rendering/RenderLayer.h:963
> +	   LayerPaintingInfo(RenderLayer* inRootLayer, const LayoutRect&
inDirtyRect, PaintBehavior inPaintBehavior, const LayoutSize&
inSubPixelAccumulation, RenderObject* inSubtreePaintRoot = 0,
OverlapTestRequestMap* inOverlapTestRequests = 0)

nullptr