[webkit-reviews] review granted: [Bug 132952] [MediaStream] RTCDtmfSender default values need to be updated. : [Attachment 231509] The patch updates the default values for RTCDTMFSender tonegap and toneduration as per the spec.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 15 06:28:36 PDT 2014
Eric Carlson <eric.carlson at apple.com> has granted Kiran
<kiran.guduru at samsung.com>'s request for review:
Bug 132952: [MediaStream] RTCDtmfSender default values need to be updated.
https://bugs.webkit.org/show_bug.cgi?id=132952
Attachment 231509: The patch updates the default values for RTCDTMFSender
tonegap and toneduration as per the spec.
https://bugs.webkit.org/attachment.cgi?id=231509&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
The changes look fine, but please add a test. A new test would be fine, or you
should be able to modify
LayoutTests/fast/mediastream/RTCPeerConnection-dtmf.html to test the min, max,
and defaults.
More information about the webkit-reviews
mailing list