[webkit-reviews] review granted: [Bug 132943] [UI-side compositing] Fix copying animations between layers, and pausing them : [Attachment 231492] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 132943: [UI-side compositing] Fix copying animations between layers, and
pausing them
https://bugs.webkit.org/show_bug.cgi?id=132943

Attachment 231492: Patch
https://bugs.webkit.org/attachment.cgi?id=231492&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231492&action=review


> Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.h:36
>  OBJC_CLASS WKAnimationDelegate;
> +OBJC_CLASS CAAnimation;

sorting

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:124
> +    void didStart(CFTimeInterval beginTime)

one line?

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:130
> +    void setHasExplicitBeginTime(bool b) { m_properties.hasExplicitBeginTime
= b; }

b :|

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:297
> +    // Copy the specific Basic or Keyframe values

period

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:763
> +	   [caAnimation.get() setValue:@YES forKey:WKExplicitBeginTimeFlag];

no .get()