[webkit-reviews] review denied: [Bug 132888] Clip Telephone Data Detector Overlay to Scrolling Range : [Attachment 231435] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 132888: Clip Telephone Data Detector Overlay to Scrolling Range
https://bugs.webkit.org/show_bug.cgi?id=132888

Attachment 231435: Patch
https://bugs.webkit.org/attachment.cgi?id=231435&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231435&action=review


> Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp:246
> +	   clipRect =
roundedIntRect(renderer.enclosingLayer()->selfClipRect());
> +	  
clipRect.setLocation(mainFrameView.contentsToRootView(clipRect.location()));

So you're computing clipRect relative to the renderer's frame, but then using
mainFrameView.contentsToRootView(). You want viewForRange.
mainFrameView.contentsToRootView(). Also does this work if the iframe is
scrolled?