[webkit-reviews] review requested: [Bug 132911] sourceFrameOnScreenForShareItem: can be off by a pixel : [Attachment 231456] Patch v1

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has asked  for review:
Bug 132911: sourceFrameOnScreenForShareItem: can be off by a pixel
https://bugs.webkit.org/show_bug.cgi?id=132911

Attachment 231456: Patch v1
https://bugs.webkit.org/attachment.cgi?id=231456&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
This splits off the client rect calculation into a utility method (which will
also be used in bug 132912), and that method is guaranteed to keep everything
in terms of floats.

Only a single rounding conversion from Float->Int rect takes place.

This fixes the known cases of off-by-one-pixel errors.