[webkit-reviews] review granted: [Bug 132846] ResourceLoadTiming should use reference instead of pointer : [Attachment 231406] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 14 10:08:49 PDT 2014


Alexey Proskuryakov <ap at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 132846: ResourceLoadTiming should use reference instead of pointer
https://bugs.webkit.org/show_bug.cgi?id=132846

Attachment 231406: Patch
https://bugs.webkit.org/attachment.cgi?id=231406&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231406&action=review


And the downside is of course that touching ResourceTiming header will make
half of WebCore rebuild, because half of WebCore indirectly includes
ResourceResponse.h.

> Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm:197
> +	   timing.domainLookupStart = domainLookupStart <= 0.0 ? -1 :
(domainLookupStart - referenceStart) * 1000;

I don't think that we ever need to compare to 0.0, can it be simply 0?


More information about the webkit-reviews mailing list