[webkit-reviews] review granted: [Bug 132891] Web Inspector: Force developerExtrasEnabled when a remote client connects : [Attachment 231418] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 132891: Web Inspector: Force developerExtrasEnabled when a remote client
connects
https://bugs.webkit.org/show_bug.cgi?id=132891

Attachment 231418: Patch
https://bugs.webkit.org/attachment.cgi?id=231418&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231418&action=review


r=me, Ultimately we should have our own way of forcing a setting on
WebCore::Settings from inside of WebCore that don't adjust the exact same bit
as WebKit APIs.

> Source/WebCore/page/PageDebuggable.cpp:103
> +    if (m_forcedDeveloperExtrasEnabled)
> +	   m_page.settings().setDeveloperExtrasEnabled(false);

This should now flip m_forcedDeveloperExtrasEnabled back to false.