[webkit-reviews] review granted: [Bug 132889] REGRESSION (topContentInset): Searching through Facebook Messenger's chat causes scrolling in News Feed : [Attachment 231412] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 132889: REGRESSION (topContentInset): Searching through Facebook
Messenger's chat causes scrolling in News Feed
https://bugs.webkit.org/show_bug.cgi?id=132889

Attachment 231412: Patch
https://bugs.webkit.org/attachment.cgi?id=231412&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231412&action=review


> Source/WebCore/platform/ScrollView.cpp:430
> +    IntSize scrollOffset = this->scrollOffset();
> +    return IntSize(scrollOffset.width(), scrollOffset.height() -
headerHeight());

return scrollOffset() - IntSize(0, headerHeight) ?

> Source/WebCore/platform/ScrollView.h:244
> +    // scrollOffset() anchors its (0,0) point at the top end of the scolling
layer. When the Page

Seems odd for a comment in ScrollView.h to be talking about layers, since this
is below the level of layer stuff. "at the top end" is odd too.