[webkit-reviews] review granted: [Bug 132876] AX: Hit testing not accounting for top content inset. : [Attachment 231396] Patch.

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Samuel White
<samuel_white at apple.com>'s request for review:
Bug 132876: AX: Hit testing not accounting for top content inset.
https://bugs.webkit.org/show_bug.cgi?id=132876

Attachment 231396: Patch.
https://bugs.webkit.org/attachment.cgi?id=231396&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231396&action=review


>>>
Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:203
>>> +	     convertedPoint.move(0, -page->topContentInset());
>> 
>> is there only ever a Y contentInset? or is there also a x content inset we
should account for
> 
> That's a great question. The bug originated from a y-axis inset issue only
and the exposed methods such as "topContentInset" have no matching
bottom/left/right equivalents.
> 
> I think we should focus this bug on just the top inset issue since it's the
only manifestation we have thus far.

as long as there are no equivalent contentInset parameters, this seems ok