[webkit-reviews] review granted: [Bug 132883] Update positioning/drawing of the image controls button : [Attachment 231404] Patch v1

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 132883: Update positioning/drawing of the image controls button
https://bugs.webkit.org/show_bug.cgi?id=132883

Attachment 231404: Patch v1
https://bugs.webkit.org/attachment.cgi?id=231404&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231404&action=review


> Source/WebCore/html/shadow/mac/ImageControlsButtonElementMac.cpp:101
> +    button->setAttribute(HTMLNames::styleAttr, String::format("right: %ipx;
top: %ipx", positionOffset.width(), positionOffset.height()));

Is this the normal way to set style attributes? I think you should be using
setInlineStyleProperty for efficiency. See my use in PDFPluginTextAnnotation.

> Source/WebCore/html/shadow/mac/imageControlsMac.css:-32
> -    right: 18px; /* FIXME: Why is right: 0px off the right edge of the
parent? */

we should keep a comment about this nonsense, because it's still wrong. just...
above.