[webkit-reviews] review granted: [Bug 132880] Add -[WKNavigationAction modifierFlags] and -[WKNavigationAction buttonNumber] : [Attachment 231398] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 132880: Add -[WKNavigationAction modifierFlags] and -[WKNavigationAction
buttonNumber]
https://bugs.webkit.org/show_bug.cgi?id=132880

Attachment 231398: Patch
https://bugs.webkit.org/attachment.cgi?id=231398&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231398&action=review


> Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm:39
> +    bool _isUserInitiated;

Please use BOOL and match the property name, _userInitiated.

> Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h:45
> +- (instancetype)initWithNavigationActionData:(const
WebKit::NavigationActionData&)navigationActionData;

This internal method’s name needs an underscore prefix.