[webkit-reviews] review denied: [Bug 132863] Remove BLOB guards : [Attachment 231371] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Tibor Mészáros
<tmeszaros.u-szeged at partner.samsung.com>'s request for review:
Bug 132863: Remove BLOB guards
https://bugs.webkit.org/show_bug.cgi?id=132863

Attachment 231371: Patch
https://bugs.webkit.org/attachment.cgi?id=231371&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=231371&action=review


Windows port doesn't enable blobs. I don't know why, perhaps it should. I'd
certainly be super happy to have Blobs enabled unconditionally, it is very
annoying and cofusing that some blob related code is enabled, and some is not.

> Source/WebCore/WebCore.exp.in:-2865
> -#if ENABLE(BLOB)
>  __ZN7WebCore12BlobRegistryD2Ev
>  __ZN7WebCore12blobRegistryEv
>  __ZN7WebCore14LoaderStrategy18createBlobRegistryEv
>  __ZTVN7WebCore12BlobRegistryE
>  __ZTVN7WebCore16BlobRegistryImplE
> -#endif

This file is alphabetically sorted, except for conditional exports. Could you
please move these lines up to maintain the rule?