[webkit-reviews] review granted: [Bug 132870] ASSERTION FAILED: leftCategory != CalcOther && rightCategory != CalcOther in WebCore::CSSCalcBinaryOperation::createSimplified : [Attachment 231384] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Martin Hodovan
<mhodovan.u-szeged at partner.samsung.com>'s request for review:
Bug 132870: ASSERTION FAILED: leftCategory != CalcOther && rightCategory !=
CalcOther in WebCore::CSSCalcBinaryOperation::createSimplified
https://bugs.webkit.org/show_bug.cgi?id=132870

Attachment 231384: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=231384&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231384&action=review


> LayoutTests/ChangeLog:8
> +	   Added test contains calc() expressions with angle, time and
frequency values,
> +	   covering all the newly introduced unit types, each of which used to
fail. 

But it doesn’t cover adding or subtracting combinations of these unit types,
and the patch adds code to handle that.

It doesn’t cover the behavior either. Need much more test coverage.

I’d also like to see tests covering serialization of these kinds of style
rules.