[webkit-reviews] review granted: [Bug 132773] Text decorations do not contribute to visual overflow : [Attachment 231363] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 13 09:00:44 PDT 2014


Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 132773: Text decorations do not contribute to visual overflow
https://bugs.webkit.org/show_bug.cgi?id=132773

Attachment 231363: Patch
https://bugs.webkit.org/attachment.cgi?id=231363&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231363&action=review


> Source/WebCore/rendering/InlineTextBox.cpp:1009
> +	       top = std::max(top, -(underlineOffset + wavyOffset -
controlPointDistance - strokeThickness));

I’m still a little puzzled by the use of std::max for top. I would have
expected std::min.

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:533
> +	   glyphOverflow.top = static_cast<int>(ceilf(top));

I’m still a little puzzled by the use of ceilf for top. I would have expected
floorf.


More information about the webkit-reviews mailing list