[webkit-reviews] review granted: [Bug 132755] WebKit2 on iOS needs to capture the main thread's floating point environment : [Attachment 231328] patch 4: addressed Geoff's feedback and fix EFL build failure.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 132755: WebKit2 on iOS needs to capture the main thread's floating point
environment
https://bugs.webkit.org/show_bug.cgi?id=132755

Attachment 231328: patch 4: addressed Geoff's feedback and fix EFL build
failure.
https://bugs.webkit.org/attachment.cgi?id=231328&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231328&action=review


r=me

> Source/WebCore/platform/ios/wak/FloatingPointEnvironment.cpp:39
> +    static NeverDestroyed<FloatingPointEnvironment> floatingPointEnv;
> +    return floatingPointEnv;

Env => Environment

> Source/WebKit2/Shared/mac/ChildProcessMac.mm:99
> +    FloatingPointEnvironment& fpenv = FloatingPointEnvironment::shared();
> +    fpenv.enableDenormalSupport();
> +    fpenv.saveMainThreadEnvironment();

fpenv => floatingPointEnvironment