[webkit-reviews] review granted: [Bug 132833] Limit number of active graphics contexts per web process : [Attachment 231349] better patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Roger Fong <roger_fong at apple.com>'s
request for review:
Bug 132833: Limit number of active graphics contexts per web process
https://bugs.webkit.org/show_bug.cgi?id=132833

Attachment 231349: better patch
https://bugs.webkit.org/attachment.cgi?id=231349&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231349&action=review


> Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:118
> +	   return 0;

return nullptr;

> Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:123
> +	   return 0;

return nullptr;

> LayoutTests/webgl/many-contexts.html:13
> +	for (var i = 0; i < size; i++) {
> +		canvii[i] = document.createElement("canvas");
> +		canvii[i].width = 1;
> +		canvii[i].height = 1;
> +		var context = canvii[i].getContext("webgl", null);
> +	}

Weird indentation.

Also, I wonder if we should check that context == null at 1000 (assuming that
we might raise the number above 16, but never to 1000).