[webkit-reviews] review granted: [Bug 132830] DataDetector UI doesn't update with resize : [Attachment 231340] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 12 16:51:38 PDT 2014
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 132830: DataDetector UI doesn't update with resize
https://bugs.webkit.org/show_bug.cgi?id=132830
Attachment 231340: Patch
https://bugs.webkit.org/attachment.cgi?id=231340&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=231340&action=review
> Source/WebCore/page/FrameView.cpp:2753
> frame().selection().setCaretRectNeedsUpdate();
> frame().selection().updateAndRevealSelection();
> + frame().selection().updateDataDetectorsForSelection();
Maybe selection can have a layoutDidChange() function that does these three
things?
More information about the webkit-reviews
mailing list